ENH: Parachute.info() method created#324
Merged
Gui-FernandesBR merged 3 commits intobeta/v1.0.0from Feb 13, 2023
Merged
Conversation
Member
Author
Member
|
@Gui-FernandesBR, can you fill out the PR description to better explain this PR? I would specially like a description of the new class architecture with this new print method. Furthermore, was this framework inspired by some other work? |
Gui-FernandesBR
changed the title
Member
Author
It's filled now. I recommend starting by the #326 . It is inspired in the #287 , see its thread for more details. |
Gui-FernandesBR
added
Enhancement
MateusStano
approved these changes
Jan 26, 2023
Member
MateusStano
left a comment
MateusStano
left a comment
There was a problem hiding this comment.
Great! Really like the __str__ method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
It is hard to plot and print information regarding the parachutes.
What is the new behavior?
Parachute class now presents more options to make or life easier when plotting everything.
Does this introduce a breaking change?